Open
Conversation
legendecas
force-pushed
the
npm_workspace
branch
from
f15f664 to
60d9ce8
Compare
legendecas
force-pushed
the
npm_workspace
branch
from
60d9ce8 to
edf046f
Compare
Member
Author
|
Going to merge this addressing a security advisary. |
KevinEady
reviewed
Apr 6, 2026
| }, | ||
| "scripts": { | ||
| "install": "npx cmake-js compile", | ||
| "install": "cmake-js compile", |
Contributor
There was a problem hiding this comment.
question: This uses cmake-js but there is no dependency entry for it. Should there be...?
bavulapati
reviewed
Apr 6, 2026
| "node-addon-api": "^8.1.0" | ||
| }, | ||
| "scripts": { | ||
| "install": "node-gyp rebuild && node test" |
There was a problem hiding this comment.
is this intentional to remove node test as well?
Member
Author
There was a problem hiding this comment.
Yes, the test should not run on install script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pins all dependencies with a workspace
package-lock.json(excluding thewebsite/folder)